Skip to content

[Gog] Setup improvements #1174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Apr 24, 2022

Conversation

imLinguin
Copy link
Member

@imLinguin imLinguin commented Mar 29, 2022

This improves compatibility with most older games.

  • Prefix creation now uses wineboot and wineserver provided with WineVersion.
  • Setup relies on root directory mounted in Z: of prefix to point to game install directory.
  • Installation also checks for INFO: Done keword in installation logs do determine if installation was successful. This will be introduced properly with next version of gogdl

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@imLinguin imLinguin added the pr:ready-for-review Feature-complete, ready for the grind! :P label Mar 29, 2022
flavioislima
flavioislima previously approved these changes Apr 2, 2022
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think looks good, left just a few comments about small concerns 👍🏽

@imLinguin imLinguin force-pushed the gog_setup_improvements branch from 327a48f to 116ba04 Compare April 2, 2022 21:03
@Nocccer
Copy link
Collaborator

Nocccer commented Apr 3, 2022

Will see over the pr today after i slepped

Nocccer
Nocccer previously requested changes Apr 3, 2022
@imLinguin imLinguin dismissed Nocccer’s stale review April 24, 2022 14:05

I'll handle V1's next time

@imLinguin imLinguin merged commit 7741661 into Heroic-Games-Launcher:main Apr 24, 2022
@imLinguin imLinguin deleted the gog_setup_improvements branch April 24, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants