-
-
Notifications
You must be signed in to change notification settings - Fork 481
[Gog] Setup improvements #1174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
imLinguin
merged 16 commits into
Heroic-Games-Launcher:main
from
imLinguin:gog_setup_improvements
Apr 24, 2022
Merged
[Gog] Setup improvements #1174
imLinguin
merged 16 commits into
Heroic-Games-Launcher:main
from
imLinguin:gog_setup_improvements
Apr 24, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flavioislima
reviewed
Apr 2, 2022
flavioislima
reviewed
Apr 2, 2022
flavioislima
reviewed
Apr 2, 2022
flavioislima
previously approved these changes
Apr 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think looks good, left just a few comments about small concerns 👍🏽
327a48f
to
116ba04
Compare
Will see over the pr today after i slepped |
Nocccer
previously requested changes
Apr 3, 2022
flavioislima
approved these changes
Apr 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves compatibility with most older games.
wineboot
andwineserver
provided with WineVersion.Z:
of prefix to point to game install directory.INFO: Done
keword in installation logs do determine if installation was successful. This will be introduced properly with next version of gogdlUse the following Checklist if you have changed something on the Backend or Frontend: